Skip to content

Make shim-array.js less breaking world around - #173

Open
a-x- wants to merge 1 commit into
montagejs:masterfrom
a-x-:patch-1
Open

Make shim-array.js less breaking world around#173
a-x- wants to merge 1 commit into
montagejs:masterfrom
a-x-:patch-1

Conversation

@a-x-

@a-x- a-x- commented Feb 8, 2017

Copy link
Copy Markdown

closes #169 collections breaks Array.from with Iterables

@hthetiot

Copy link
Copy Markdown
Contributor

lgtm

@hthetiot hthetiot added this to the 5.0.x milestone May 5, 2017
@hthetiot
hthetiot self-requested a review May 5, 2017 19:51
@hthetiot hthetiot self-assigned this Dec 7, 2017
@hthetiot

hthetiot commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

Can you rebase on master @a-x- ?

@a-x-

a-x- commented Dec 7, 2017

Copy link
Copy Markdown
Author

done

@hthetiot

hthetiot commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

Some test still break I will check why.

@hthetiot hthetiot modified the milestones: 5.1.x, 6.x Dec 28, 2017
@hthetiot

Copy link
Copy Markdown
Contributor

Need refactor to use internals if not extended.

@a-x-

a-x- commented Jan 15, 2018

Copy link
Copy Markdown
Author

could you add an example?

As I understand someone may keep native, say, window.Array, but change its Array.prototype.some method.
And you propose to replace whole Array In this case.

Am I correct?

@hthetiot

hthetiot commented Feb 16, 2018

Copy link
Copy Markdown
Contributor

@a-x- Sorry I really like to have that merge for fixing #196 but your changes break the tests.

As I understand someone may keep native, say, window.Array, but change its Array.prototype.some method.
And you propose to replace whole Array In this case.

No.

What I propose is make sure collections internally use his Array functions if there have a difference with Native Array or use private functions if needed.

@hthetiot

hthetiot commented Feb 16, 2018

Copy link
Copy Markdown
Contributor

@a-x- I cannot merge if test fails.

to run test:

npm run test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

collections breaks Array.from with Iterables

2 participants